Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Validate Shape Zero fix repair action + provide informational artist-facing report #5524

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Aug 28, 2023

Changelog Description

Refactor to PublishValidationError to allow the RepairAction to work + provide informational report message

Additional info

Fixes #5456

Example report:

image

Testing notes:

  1. Make sure to enable the plug-in in settings: project_settings/maya/publish/ValidateShapeZero/enabled
  2. Publish a model family with geometry with component tweaks, e.g.
    • Create a cube
    • Delete history
    • Move one vertex in edit mode (this is now a component tweak)

@BigRoy BigRoy requested a review from antirotor August 28, 2023 14:25
@ynbot ynbot added type: bug Something isn't working host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Aug 28, 2023
@BigRoy BigRoy requested a review from LiborBatek August 28, 2023 14:59
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Maya 2023 successfully and code looks good.

@iLLiCiTiT iLLiCiTiT merged commit 6f683ee into ynput:develop Sep 1, 2023
@ynbot ynbot added this to the next-patch milestone Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Maya: Shape Zero validator doesn't show repair action
5 participants